[PATCH] D70908: [scudo][standalone] Add chunk ownership function

Mitch Phillips via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 2 11:47:40 PST 2019


hctim added a comment.

So the model presented asserts that if the chunk header is truncated, the pointer is not owned by us. Is this WAI? I can forsee that a chunk header was truncated, and then the pointer to the associated allocation is checked for ownership, which the ownership will fail as the chunk header check didn't succeed.



================
Comment at: compiler-rt/lib/scudo/standalone/combined.h:482
 
+  static_assert(MinAlignment >= sizeof(Chunk::PackedHeader), "");
+
----------------
Why blank assert log here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70908/new/

https://reviews.llvm.org/D70908





More information about the llvm-commits mailing list