[PATCH] D70735: [ADT] Add non-const operator* to iterator_adaptor_base and df_iterator.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 2 07:58:38 PST 2019


dblaikie added a comment.

Could you add some test coverage (showing what would break, specifically - an iterator with only a const op* being adapted that would previously (well, previous to this patch, so currenctly in tree - might just take updating an existing iterator in the test case to fall into this situation) fail to compile) to llvm/unittests/ADT/IteratorTest.cpp


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70735/new/

https://reviews.llvm.org/D70735





More information about the llvm-commits mailing list