[PATCH] D67463: [MS] Warn when shadowing template parameters under -fms-compatibility

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added a comment.

You probably already know this, but the behavior between MSVC & Clang is different as to the value of the constant (testcase for PR43265).
See: https://godbolt.org/z/y4uvgp
Clang gives 0, while MSVC gives 5. This incompatibility is a potential source of failure, one of our tests broke because of that.

Do you think this patch could/should be back-ported into 9.0.1? At least having the warning gives an indication about a potential failure.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67463/new/

https://reviews.llvm.org/D67463