[PATCH] D70720: [llvm-objdump] Display locations of variables alongside disassembly

[Oliver Stannard (Linaro) via Phabricator via llvm-commits]

ostannard updated this revision to Diff 231529.
ostannard retitled this revision from "[RFC/WIP][llvm-objdump] Display locations of variables alongside disassembly" to "[llvm-objdump] Display locations of variables alongside disassembly".
ostannard edited the summary of this revision.
ostannard added reviewers: echristo, eugenis, jhenderson, jmorse, silvas.
ostannard added a comment.
Herald added a subscriber: jsji.
Herald added a reviewer: jdoerfert.

Now ready for review:

- Added tests, including a more complex expression emitted by GCC, and high register numbers needed for PPC.
- Print parentheses when needed by complex expressions, matching C operator precedence.
- Add command-line option to docs.
- Work correctly with `-S` and `-l` options (interleaved source code and line numbers), remove extra line number printing I added before I realised those options exist.

There are still a number of TODOs, in particular in the expression printer, but they can be addressed later, if those expressions turn up in real object files.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70720/new/

https://reviews.llvm.org/D70720

Files:
  llvm/docs/CommandGuide/llvm-objdump.rst
  llvm/include/llvm/DebugInfo/DWARF/DWARFExpression.h
  llvm/include/llvm/Support/FormattedStream.h
  llvm/lib/Support/FormattedStream.cpp
  llvm/test/tools/llvm-objdump/ARM/Inputs/debug.c
  llvm/test/tools/llvm-objdump/ARM/debug-vars-dwarf4-sections.s
  llvm/test/tools/llvm-objdump/ARM/debug-vars-dwarf4.s
  llvm/test/tools/llvm-objdump/ARM/debug-vars-dwarf5-sections.s
  llvm/test/tools/llvm-objdump/ARM/debug-vars-dwarf5.s
  llvm/test/tools/llvm-objdump/ARM/debug-vars-precedence.s
  llvm/test/tools/llvm-objdump/PowerPC/debug-vars.s
  llvm/tools/llvm-objdump/llvm-objdump.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70720.231529.patch
Type: text/x-patch
Size: 154469 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191129/4280e0ae/attachment-0001.bin>