[PATCH] D70431: [DebugInfo] Make describeLoadedValue() reg aware

David Stenberg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 28 07:52:35 PST 2019


dstenb marked 7 inline comments as done.
dstenb added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrInfo.cpp:7586
+  assert(MI.getOpcode() == X86::MOV32rr && "Unexpected super-register case");
+  return ParamLoadedValue(MachineOperand::CreateReg(SrcReg, false), Expr);
+}
----------------
djtodoro wrote:
> So, this covers all the cases of the s//uper-registers// except the `X86::MOV32rr` case?
Sorry, what is the question here? We only handle MOV32rr there (?).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70431/new/

https://reviews.llvm.org/D70431





More information about the llvm-commits mailing list