[PATCH] D70298: [LV] Avoid considering scalar-with-predication instructions as also uniform-after-vectorization, fix PR40816

Thu Nov 28 09:52:59 PST 2019

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

In the test case we predicate due to low trip count right? It might be worth calling that out.

Also, it would be great if the test could be simplified a bit more (e.g. make the phi and related values i16, get rid of the truncation and the multiply). It seems like the test is not the most robust, as the load feeding the compare is not used at all after vectorisation, but I’m not sure if there’s another easy way to mark it as uniform at the moment.

LGTM thanks, any test improvements would be a nice bonus :) I agree that in most cases it’s unlikely that replicating a few uniform instructions will have a big impact.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70298/new/

https://reviews.llvm.org/D70298