[PATCH] D68717: [Codegen] More add_sat and sub_sat promotion

[Dave Green via Phabricator via llvm-commits]

dmgreen updated this revision to Diff 231442.
dmgreen added a comment.
This revision is now accepted and ready to land.

Sorry for the delay. Now that I have added some extra Neon codegen (and some extra tests), this is how this looks.

The unsigned cases still look like a clear win. The signed cases looks worse (although you could argue in cases that this would simplify if part of a loop).

WDYT? Remove the signed part and keep the unsigned?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68717/new/

https://reviews.llvm.org/D68717

Files:
  llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp
  llvm/test/CodeGen/AArch64/sadd_sat_vec.ll
  llvm/test/CodeGen/AArch64/ssub_sat_vec.ll
  llvm/test/CodeGen/AArch64/uadd_sat_vec.ll
  llvm/test/CodeGen/AArch64/usub_sat_vec.ll
  llvm/test/CodeGen/Thumb2/mve-saturating-arith.ll
  llvm/test/CodeGen/X86/sadd_sat_vec.ll
  llvm/test/CodeGen/X86/ssub_sat_vec.ll
  llvm/test/CodeGen/X86/uadd_sat_vec.ll
  llvm/test/CodeGen/X86/usub_sat_vec.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68717.231442.patch
Type: text/x-patch
Size: 47837 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191128/fcc9e45e/attachment-0001.bin>