[PATCH] D70810: [llvm-readelf/llvm-readobj] - Check version of SHT_GNU_verdef section entries when dumping.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 28 03:53:47 PST 2019


grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/elf-verdef-invalid.test:238
+
+## Check how we handle the case when a version definition entry has an unsupported version.
+
----------------
jhenderson wrote:
> This can be simplified to "Check how we handle a version definition entry with an unsupported version."
> 
> There may be other places where this sort of suggestion applies too. Sorry for not highlighting it before.
Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70810/new/

https://reviews.llvm.org/D70810





More information about the llvm-commits mailing list