[PATCH] D70431: [DebugInfo] Make describeLoadedValue() reg aware

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 28 01:31:05 PST 2019


djtodoro added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetInstrInfo.h:960
   /// If the specific machine instruction is an instruction that adds an
-  /// immediate value to its source operand and stores it in destination,
-  /// return destination and source registers as machine operands along with
-  /// \c Offset which has been added.
-  virtual Optional<DestSourcePair> isAddImmediate(const MachineInstr &MI,
-                                                  int64_t &Offset) const {
+  /// immediate value and a physical register and stores the result in
+  /// the given physical register \c Reg, return a pair of the source
----------------
djtodoro wrote:
> `and a physical register and stores, and stores the`
`and a physical register and stores` ==> `and a physical register, and stores the`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70431/new/

https://reviews.llvm.org/D70431





More information about the llvm-commits mailing list