[PATCH] D70121: [DebugInfo][LDV] Teach LDV how to identify source variables and handle fragments

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando updated this revision to Diff 231246.
Orlando added a comment.

Ping.

+ Update dexter test for @jmorse.
+ Small additional change to print().
+ Rebase.
+ Rephrase a small part of the summary.

@djtodoro said:

> Please consider splitting this into two or more patches (i.e. one for NFC and one teaching functionality)

I'm not sure if that's possible here. Everything seems quite interdependent, and the bug fix (functionality change) happens as a result of the structural change (also a functionality change).
I could split this into two or more dependant patches and keep 'related' things together. For example, put all the debug print() updates in a single patch. Not sure that this would this help though, what do you think?
There is a very small change/fix to `DbgValueLocation` which I included in this patch. I could take that out (and probably should) but it won't have a noticable impact on the diff size.

@aprantl since your last review I've updated the class names and summary, how do you feel about these changes?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70121/new/

https://reviews.llvm.org/D70121

Files:
  debuginfo-tests/dexter-tests/coalesce_dbg_values.cpp
  llvm/lib/CodeGen/LiveDebugVariables.cpp
  llvm/test/DebugInfo/ARM/PR26163.ll
  llvm/test/DebugInfo/MIR/X86/live-debug-vars-unused-arg-debugonly.mir
  llvm/test/DebugInfo/X86/dbg-addr-dse.ll
  llvm/test/DebugInfo/X86/live-debug-vars-dse.mir
  llvm/test/DebugInfo/pr41992.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70121.231246.patch
Type: text/x-patch
Size: 44755 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191127/47aeaabd/attachment.bin>