[PATCH] D70757: [ms] Add @feat.00 magic symbol to COFF object files from AsmParser

[Reid Kleckner via Phabricator via llvm-commits]

rnk requested changes to this revision.
rnk added a comment.
This revision now requires changes to proceed.

I don't think we should do this implicitly. Assembler should be a low level representation of what the programmer wants in the symbol table. That includes @feat.00. There is existing nasm documentation covering this. Basically, this is something the programmer has to know if they want to target windows:
https://nasm.us/doc/nasmdoc7.html

There are a couple of other @feat.00 bits that the compiler could set. Wouldn't this create problems then with clang -save-temps, where we parse the .s output and assemble it? I'd expect the default @feat.00 and the explicit one in the .s file to conflict.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70757/new/

https://reviews.llvm.org/D70757