[PATCH] D70007: [Intrinsic] Add fixed point division intrinsics.

Wed Nov 27 14:36:38 PST 2019

leonardchan added a comment.

Sorry for the holdup. Right now I'm just writing a bunch of tests to validate the IR expansion produces the correct division results. As of now, the patch LGTM, but I'd prefer holding off submitting the revision until I finish validating (unless you think it's better to submit now then fix any potential bugs that may be found later since I don't think anyone will be immediately using this). Here's a few comments I have so far:

- This will need another rebase. I ran into a merge conflict this morning against ToT.
- I think `@llvm.sdiv.fix.i4(i4 -2, i4 2, i32 0)` produces the incorrect result. This returns `-2` instead of `-1`. I'm looking over the patch to see what could've caused it, but you might be able to find it faster than I can.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70007/new/

https://reviews.llvm.org/D70007