[PATCH] D70461: [AIX] Emit TOC entries for ASM printing

Digger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 27 08:45:25 PST 2019


DiggerLin added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:45
 #include "llvm/IR/DataLayout.h"
+#include "llvm/IR/GlobalObject.h"
 #include "llvm/IR/GlobalValue.h"
----------------
file llvm/IR/GlobalVariable.h already include the  GlobalObject.h.

the  #include "llvm/IR/GlobalObject.h" do not need.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1464
       if (isPPC64) {
-        TS.emitTCEntry(*TOCEntryTarget);
+        TS.emitTCEntry(*TOCEntryTarget,*TOCEntryTarget);
       } else {
----------------
I agree with jason, since  we always have ".tc A[TC], A",  we do not need to change the  interface of function emitTCEntry()


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70461/new/

https://reviews.llvm.org/D70461





More information about the llvm-commits mailing list