[PATCH] D70776: [llvm-readelf] - Make GNU style dumping of invalid SHT_GNU_verdef be consistent with LLVM style.

[George Rimar via Phabricator via llvm-commits]

grimar planned changes to this revision.
grimar added a comment.

In D70776#1761542 <https://reviews.llvm.org/D70776#1761542>, @jhenderson wrote:

> In D70776#1761511 <https://reviews.llvm.org/D70776#1761511>, @grimar wrote:
>
> > In D70776#1761507 <https://reviews.llvm.org/D70776#1761507>, @jhenderson wrote:
> >
> > > Looks okay to me. What does GNU do in this situation?
> >
> >
> > It prints:
> >
> >   readelf: Warning: Section 1 has an out of range sh_link value of 255
> >  
> >   Version definition section '.gnu.version_d' contains 0 entries:
> >     Addr: 0x0000000000000000  Offset: 0x000040  Link: 255 (<corrupt>)
> >
>
>
> Okay, thanks. Should we maybe print `<corrupt>` too, instead of `<invalid>`? I don't mind either way.


I'll change to "corrupt" for consistency.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70776/new/

https://reviews.llvm.org/D70776