[PATCH] D69828: [WIP][OpenMP] Lower taskwait using OpenMP IR Builder

[Roger Ferrer Ibanez via Phabricator via llvm-commits]

rogfer01 added a comment.

In D69828#1761133 <https://reviews.llvm.org/D69828#1761133>, @jdoerfert wrote:

> > Also for taskwait inside untied tasks we should be reusing the available global_tid instead of calling __kmpc_global_thread_num again.
>
> FWIW, We will just clean up in a later pass (under review). We have to do that anyway, adding some smarts here is barely worth it and I also removed similar logic from my patches.


Sure. I actually forgot to update the summary because you already mentioned this IIRC.



================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:6370
+    auto IP = OMPBuilder->CreateTaskwait(CGF.Builder);
+    if (!IP.getBlock())
+      return;
----------------
This is to preserve exactly the same behaviour as before.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69828/new/

https://reviews.llvm.org/D69828