[PATCH] D70648: [mips] Fix sc, scs, ll, lld instructions expanding

[Simon Atanasyan via Phabricator via llvm-commits]

atanasyan marked an inline comment as done.
atanasyan added inline comments.


================
Comment at: llvm/lib/Target/Mips/AsmParser/MipsAsmParser.cpp:3745
+
+      if (ABI.ArePtrs64bit() && isGP64bit()) {
+        MCOperand HighestOperand = MCOperand::createExpr(
----------------
Petar.Avramovic wrote:
> isGP64bit() feel more like an assert here or in ArePtrs64bit().
> `ABI.ArePtrs64bit() ? Mips::DADDu : Mips::ADDu` implies that gpr are 64 bit when pointers are 64.
> Flags: `llvm-mc -triple mips64el -mattr=-gp64 ...` make subtarget with N64 and no gp64, and this works like O32?
It's a result of copy-paste. I think `if (ABI.IsN64())` condition is enough here.

Thanks for review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70648/new/

https://reviews.llvm.org/D70648