[PATCH] D70690: [ELF][ARM] Add ARM::isBranchRangeBeforePCBias to remove assumption on implicit addends being -8 (ARM) or -4 (Thumb)

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 26 00:34:26 PST 2019


grimar added inline comments.


================
Comment at: lld/ELF/Arch/ARM.cpp:391
+    break;
+  }
+  return inBranchRange(type, src, dst);
----------------
nit: I guess using `if` might be a bit nicer and shorter here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70690/new/

https://reviews.llvm.org/D70690





More information about the llvm-commits mailing list