[PATCH] D70367: Fix for AMDGPU MUL_I24 known bits calculation

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/amdgpu-mul24-knownbits.ll:2
+
+; FUNC-LABEL: {{^}}test_mul24_knownbits_kernel:
+; RUN: llc -mtriple amdgcn-amd-amdhsa -mcpu=gfx900 -mattr=-code-object-v3 -O2 -amdgpu-function-calls=0 < %s | FileCheck --check-prefix=GCN %s
----------------
FUNC isn’t specified as a check prefix, but there’s also no reason to use a second prefix 


================
Comment at: llvm/test/CodeGen/AMDGPU/amdgpu-mul24-knownbits.ll:3
+; FUNC-LABEL: {{^}}test_mul24_knownbits_kernel:
+; RUN: llc -mtriple amdgcn-amd-amdhsa -mcpu=gfx900 -mattr=-code-object-v3 -O2 -amdgpu-function-calls=0 < %s | FileCheck --check-prefix=GCN %s
+; GCN-NOT: -128
----------------
Run line should be first. Most of the flags to llc can also be removed 


================
Comment at: llvm/test/CodeGen/AMDGPU/amdgpu-mul24-knownbits.ll:4
+; RUN: llc -mtriple amdgcn-amd-amdhsa -mcpu=gfx900 -mattr=-code-object-v3 -O2 -amdgpu-function-calls=0 < %s | FileCheck --check-prefix=GCN %s
+; GCN-NOT: -128
+; Function Attrs: alwaysinline convergent norecurse nounwind
----------------
Should use positive checks. I don’t know what this would exclude since we won’t emit anything with dashes


================
Comment at: llvm/test/CodeGen/AMDGPU/amdgpu-mul24-knownbits.ll:5
+; GCN-NOT: -128
+; Function Attrs: alwaysinline convergent norecurse nounwind
+define weak_odr amdgpu_kernel void @test_mul24_knownbits_kernel(float addrspace(1)* %p) #4 {
----------------
Drop this comment 


================
Comment at: llvm/test/CodeGen/AMDGPU/amdgpu-mul24-knownbits.ll:17
+}
+
+; Function Attrs: nounwind readnone speculatable
----------------
Should probably merge this with the other mul24 test files 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70367/new/

https://reviews.llvm.org/D70367