[PATCH] D69281: [FPEnv] Constrained FCmp intrinsics

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 25 18:27:00 PST 2019


craig.topper added a comment.

In D69281#1759494 <https://reviews.llvm.org/D69281#1759494>, @andrew.w.kaylor wrote:

> I would prefer a single intrinsic/opcode with additional predicates to handle signalling vs. quiet. My main reason is consistency with how the IEEE-754 spec describes comparisons, but that's a weak argument. @craig.topper mentioned to me that there are some additional opcodes that might need to be duplicated if you treat signalling and quiet as separate operations.


I was referring to SELECT_CC and BR_CC. If we have a separate STRICT_FSETCC for signalling and quiet, then we we'll need separate STRICT_SELECT_CC/BR_CC if for signalling and quiet.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69281/new/

https://reviews.llvm.org/D69281





More information about the llvm-commits mailing list