[PATCH] D70695: [ELF] Support input section description .rel[a].dyn in /DISCARD/

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 25 14:10:40 PST 2019


MaskRay added a comment.

A gvisor <https://gvisor.dev/> developer reported that .rela.dyn cannot be discarded. I find that supporting .rela.dyn does not even need extra code, so let's do it. We can support .relr.dyn as well, but it may need more work, so I don't include it in this patch.

  // SyntheticSections.cpp
      addSize(config->useAndroidRelrTags ? DT_ANDROID_RELRSZ : DT_RELRSZ,
              part.relrDyn->getParent());  // If .relr.dyn is allowed to be discarded, part.relrDyn->getParent() will be null and part.relrDyn->getParent()->size will dereference a null pointer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70695/new/

https://reviews.llvm.org/D70695





More information about the llvm-commits mailing list