[PATCH] D68857: [X86] Add strict fp support for operations of X87 instructions

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:5227
+    // X87 instructions has enabled these strict fp operation.
+    if (!Subtarget->hasSSE1() && Subtarget->hasX87())
+      break;
----------------
This isn't the right check for the fp80 operations. They're independent of sse.


================
Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:5228
+    if (!Subtarget->hasSSE1() && Subtarget->hasX87())
+      break;
   case ISD::STRICT_FP_TO_SINT:
----------------
Need an LLVM_FALLTHROUGH marker here


================
Comment at: llvm/test/CodeGen/X86/fp80-strict-scalar.ll:3
+; RUN: llc < %s -mtriple=i686-unknown-unknown -mattr=-sse -O3 -disable-strictnode-mutation | FileCheck %s --check-prefixes=CHECK,X86
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=-sse -O3 -disable-strictnode-mutation | FileCheck %s --check-prefixes=CHECK,X64
 
----------------
Why are we disabling sse on x86_64?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68857/new/

https://reviews.llvm.org/D68857