[PATCH] D69868: Allow "callbr" to return non-void values

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 25 10:45:37 PST 2019


nickdesaulniers added a comment.

In D69868#1758211 <https://reviews.llvm.org/D69868#1758211>, @void wrote:

> Ping? :-)


Sorry, busy week going into Thanksgiving holiday.  I really think this needs more time to bake in code review and input from @jyknight  (and maybe @rnk ).  Particularly, re-reading through the thread (https://lists.llvm.org/pipermail/llvm-dev/2019-June/133428.html), I'm curious to see more tests for cases that we don't expect to work, particularly for the clang patch I'm curious if we can somehow warn the user?

Should you add a test case here for the case @jyknight describes in: https://lists.llvm.org/pipermail/llvm-dev/2019-June/133431.html (ie. differing output constraints)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69868/new/

https://reviews.llvm.org/D69868





More information about the llvm-commits mailing list