[PATCH] D70304: [Loop Peeling] Add possibility to enable peeling on loop nests.

Arkady Shlykov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 25 08:43:00 PST 2019


ashlykov added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopUnrollPass.cpp:158
+static cl::opt<bool> UnrollAllowLoopNestsPeeling(
+    "unroll-allow-loop-nests-peeling", cl::init(false), cl::Hidden,
+    cl::desc("Allows loop nests to be peeled."));
----------------
fhahn wrote:
> xbolva00 wrote:
> > enable by default?
> > 
> > or atleast for x86?
> I don't think that would be good idea, without at least some analysis on the impact on code size on targets turning this on. The cost-model currently assumes innermost loops exclusively.
The change is intended to be enabled on per-target basis via TTI where it's profitable. If someone could supply enough benchmarking for e.g. x86 target we can proceed further with enabling it/adjusting cost-model.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70304/new/

https://reviews.llvm.org/D70304





More information about the llvm-commits mailing list