[PATCH] D70443: [AIX][XCOFF] Generate undefined symbol in symbol table for external function call

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 25 08:37:43 PST 2019


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:5338
+          Context.getXCOFFSection(S->getName(), XCOFF::XMC_PR, XCOFF::XTY_ER,
+                                  XCOFF::C_EXT, SectionKind::getMetadata());
+      S->setContainingCsect(Sec);
----------------
Does it make sense to check the linkage on the function? What if it is weak?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70443/new/

https://reviews.llvm.org/D70443





More information about the llvm-commits mailing list