[llvm] 2068409 - [InstCombine] simplify loop for shuffle mask canonicalization; NFC

[Sanjay Patel via llvm-commits]

Author: Sanjay Patel
Date: 2019-11-25T10:41:50-05:00
New Revision: 20684092ab600d166f0346485945d5d618b08420

URL: https://github.com/llvm/llvm-project/commit/20684092ab600d166f0346485945d5d618b08420
DIFF: https://github.com/llvm/llvm-project/commit/20684092ab600d166f0346485945d5d618b08420.diff

LOG: [InstCombine] simplify loop for shuffle mask canonicalization; NFC

Added: 
    

Modified: 
    llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp b/llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp
index 54298949cbab..eae8bd7452d4 100644
--- a/llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp
+++ b/llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp
@@ -1893,18 +1893,18 @@ Instruction *InstCombiner::visitShuffleVectorInst(ShuffleVectorInst &SVI) {
   if (LHS == RHS || isa<UndefValue>(LHS)) {
     // Remap any references to RHS to use LHS.
     SmallVector<Constant*, 16> Elts;
-    for (unsigned i = 0, e = LHSWidth; i != VWidth; ++i) {
+    for (unsigned i = 0; i != VWidth; ++i) {
       if (Mask[i] < 0) {
         Elts.push_back(UndefValue::get(Int32Ty));
         continue;
       }
 
-      if ((Mask[i] >= (int)e && isa<UndefValue>(RHS)) ||
-          (Mask[i] <  (int)e && isa<UndefValue>(LHS))) {
+      if ((Mask[i] >= (int)LHSWidth && isa<UndefValue>(RHS)) ||
+          (Mask[i] <  (int)LHSWidth && isa<UndefValue>(LHS))) {
         Mask[i] = -1;     // Turn into undef.
         Elts.push_back(UndefValue::get(Int32Ty));
       } else {
-        Mask[i] = Mask[i] % e;  // Force to LHS.
+        Mask[i] = Mask[i] % LHSWidth;  // Force to LHS.
         Elts.push_back(ConstantInt::get(Int32Ty, Mask[i]));
       }
     }