[PATCH] D70373: [NFC] [PowerPC] Add volatile flag to a swap optimization test

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 25 06:57:46 PST 2019


jsji requested changes to this revision.
jsji added a comment.
This revision now requires changes to proceed.

I agree with @lkail and @steven.zhang , I don't think we should update these testcases just to avoid updating them in another patch.

I believe keeping them as it is will catch more regression than adding `volatile` to them .


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70373/new/

https://reviews.llvm.org/D70373





More information about the llvm-commits mailing list