[PATCH] D70597: [PHIEliminate] skip dbg instruction when LowerPHINode

Chris Ye via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 25 03:38:08 PST 2019


yechunliang added a comment.

Updated the code and here is the description:

> 
> 
>   [PHIEliminate] skip dbg instruction when LowerPHINode
>    
>    - Debug instruction should not impact PHI node lowering when DBG_VALUE exist between PHI and LABEL.
>    Eliminating PHI should skip debug instruction and insert copy instruction after LABEL.
>    
>    - API refactor: delete LastPHIIt and pass the caller with AfterPHIsIt directly to simplify code.
>    The previous interface to LowerPHINode is strange:
>        a) Before LowerPHINode, we get the prev() of last PHI/etc
>        b) LowerPHINode does next() to get first non-PHI/etc to compute AfterPHIsIt
>    
>    Fix issue: https://bugs.llvm.org/show_bug.cgi?id=43859




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70597/new/

https://reviews.llvm.org/D70597





More information about the llvm-commits mailing list