[PATCH] D70587: [SLP] Enhance SLPVectorizer to vectorize different combinations of aggregates

[Anton Afanasyev via Phabricator via llvm-commits]

anton-afanasyev marked 3 inline comments as done.
anton-afanasyev added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:637
   /// \returns number of elements in vector if isomorphism exists, 0 otherwise.
   unsigned canMapToVector(Type *T, const DataLayout &DL) const;
 
----------------
RKSimon wrote:
> Update the description?
Yes, done.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:6963
+                                            IE->getType(),
+                                            CI->getZExtValue());
+      }
----------------
RKSimon wrote:
> If the insertion index isn't constant we should call getVectorInstrCost with a ~0/-1 value
Hmm, what is `~0/-1` value exactly?
Also, I'm not sure the cost tuning is related to this commit -- the current logic is taken unchanged as it was before.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70587/new/

https://reviews.llvm.org/D70587