[PATCH] D70545: [ARM][MVE][Intrinsics] Add MVE VABD intrinsics.

Mon Nov 25 02:45:33 PST 2019

dmgreen added inline comments.

================
Comment at: clang/include/clang/Basic/arm_mve.td:33
 let params = T.Int in {
+def vabdq: Intrinsic<Vector, (args Vector:$a, Vector:$b), (IRInt<"vabd", [Vector]> $a, $b)>;
 def vaddq: Intrinsic<Vector, (args Vector:$a, Vector:$b), (add $a, $b)>;
----------------
Can this and vadbqf below be combined into one using T.Usual?

I believe the differences only usually come from "fadd" being different to "add". If they are both intrinsics (which sounds good to me for abd), then they can more happily live together.

================
Comment at: clang/test/CodeGen/arm-mve-intrinsics/vabdq.c:13
+uint32x4_t test_vabdq_u32(uint32x4_t a, uint32x4_t b)
+{
+#ifdef POLYMORPHIC
----------------
More tests please.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70545/new/

https://reviews.llvm.org/D70545