[PATCH] D70660: Add initial tests for update_{llc,cc}_test_checks.py

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 25 02:15:51 PST 2019


arichardson created this revision.
arichardson added reviewers: xbolva00, MaskRay, jdoerfert.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This commit adds two basic tests for these update script to validate that
they still work as expected. In the future we could extend these tests
whenever new features are added to avoid introducing regressions.

I am not sure this is the best approach for testing, but it did allow me to find a python2.7 compat issue that I introduced in D70432 <https://reviews.llvm.org/D70432>.
If this approach seems fine, I'll also add a basic test for the remaining update scripts.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D70660

Files:
  llvm/test/tools/UpdateTestChecks/lit.local.cfg
  llvm/test/tools/UpdateTestChecks/update_cc_tests/Inputs/mangled_names.c
  llvm/test/tools/UpdateTestChecks/update_cc_tests/lit.local.cfg
  llvm/test/tools/UpdateTestChecks/update_cc_tests/mangled_names.test
  llvm/test/tools/UpdateTestChecks/update_llc_tests/Inputs/basic.ll
  llvm/test/tools/UpdateTestChecks/update_llc_tests/basic.test
  llvm/test/tools/UpdateTestChecks/update_llc_tests/lit.local.cfg

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70660.230856.patch
Type: text/x-patch
Size: 15516 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191125/08f37eaa/attachment.bin>


More information about the llvm-commits mailing list