[PATCH] D68857: [X86] Add strict fp support for operations of X87 instructions

LiuChen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 21 23:19:27 PST 2019


LiuChen3 added a comment.

In D68857#1755370 <https://reviews.llvm.org/D68857#1755370>, @RKSimon wrote:

> The new tests and test renames can be done as an NFC commit - then please rebase this patch


Sorry, I am not clear of what you mean. Do you mean I should make a new patch to add these tests?  The tests in my current patch is not just  renamed, but also doing functional test. I think it's better to keep them together.
And I think make a new patch to rename the tests is reasonable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68857/new/

https://reviews.llvm.org/D68857





More information about the llvm-commits mailing list