[PATCH] D70505: [ELF] Replace SymbolTable::forEachSymbol with iterator_range symbols()

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 21 16:28:49 PST 2019


MaskRay updated this revision to Diff 230562.
MaskRay retitled this revision from "[ELF] Replace SymbolTable::forEachSymbol with filter_iterator begin()/end()" to "[ELF] Replace SymbolTable::forEachSymbol with iterator_range symbols()".
MaskRay edited the summary of this revision.
MaskRay added a comment.

> I can see some benefit in `for (Symbol *sym : symtab->symbols())` as it is not clear from `sym : symtab` that PlaceHolder's are being skipped.

begin()/end() -> symbols()


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70505/new/

https://reviews.llvm.org/D70505

Files:
  lld/ELF/Driver.cpp
  lld/ELF/LTO.cpp
  lld/ELF/MarkLive.cpp
  lld/ELF/Relocations.cpp
  lld/ELF/SymbolTable.h
  lld/ELF/Writer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70505.230562.patch
Type: text/x-patch
Size: 7557 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191122/1ffcf2ae/attachment.bin>


More information about the llvm-commits mailing list