[PATCH] D70570: [PowerPC] Only use PLT annotations if using PIC relocation model

Justin Hibbits via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 21 14:39:39 PST 2019


jhibbits created this revision.
jhibbits added reviewers: PowerPC, hfinkel, nemanjai.
Herald added subscribers: llvm-commits, steven.zhang, shchenz, jsji, kbarton, hiraditya.
Herald added a project: LLVM.

The default static (non-PIC, non-PIE) model for 32-bit powerpc does not
use @PLT annotations and relocations in GCC.  LLVM shouldn't use @PLT
annotations either, because it breaks secure-PLT linking with GNU LD.

Update the available-externally.ll test to reflect that default mode should be
the same as the static relocation, by using the same check prefix.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D70570

Files:
  llvm/lib/Target/PowerPC/PPCISelLowering.cpp
  llvm/test/CodeGen/PowerPC/2008-10-28-f128-i32.ll
  llvm/test/CodeGen/PowerPC/2010-02-12-saveCR.ll
  llvm/test/CodeGen/PowerPC/available-externally.ll
  llvm/test/CodeGen/PowerPC/srem-lkk.ll
  llvm/test/CodeGen/PowerPC/stubs.ll
  llvm/test/CodeGen/PowerPC/umulo-128-legalisation-lowering.ll
  llvm/test/CodeGen/PowerPC/urem-lkk.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70570.230539.patch
Type: text/x-patch
Size: 6011 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191121/353e3ac2/attachment.bin>


More information about the llvm-commits mailing list