[PATCH] D70079: [SelectionDAG] Combine U{ADD,SUB}O diamonds into {ADD,SUB}CARRY

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

In D70079#1752986 <https://reviews.llvm.org/D70079#1752986>, @davezarzycki wrote:

> Unless I'm misunderstanding you, I think the many rounds of review feedback are clouding the code review. Lines 2874 and 2875 replace Carry1's result 0 in all cases (OR, XOR, and AND).


Doesn't line 2873 return if the opcode is not ISD::AND?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70079/new/

https://reviews.llvm.org/D70079