[PATCH] D70259: [Error] Add source location to cantFail

Don Hinton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 19 14:06:16 PST 2019


hintonda added a comment.

@lhames, I think I've applied all your verbal changes, but please let me 
know if I missed anything.

Essentially, previous behavior is maintained, but users can opt-in to the 
new behavior, adding file and line numbers, by switching to the new macro.  
I also updated all of llvm, but excluded other projects for the time being.  
Most of them use `llvm::cantFail`, and could be updated as needed via a 
script, e.g., something like this would do it:

  find clang -type f \( -name "*.cpp" -o -name "*.h" \) -exec grep -l "cantFail" \{\} \; | xargs sed -i.bak 's/llvm::cantFail/llvm_cantFail/' 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70259/new/

https://reviews.llvm.org/D70259





More information about the llvm-commits mailing list