[PATCH] D70420: Use lld::make<T> to make TpiSource objects

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

We make O(#objects) of these, and they live for the lifetime of the link.



================
Comment at: lld/COFF/DebugTypes.h:35
+  TpiSource(TpiKind k, const ObjFile *f) : kind(k), file(f) {}
   virtual ~TpiSource() {}
 
----------------
nit, but if you put the ctor and dtor out of line, you will achieve the object size saving goals of this LLVM coding guideline:
https://llvm.org/docs/CodingStandards.html#provide-a-virtual-method-anchor-for-classes-in-headers


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70420/new/

https://reviews.llvm.org/D70420