[PATCH] D70425: [APFloat] Fix construction of APFloat with FP value instead of integer

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 19 07:16:44 PST 2019


hfinkel added a comment.

In D70425#1751548 <https://reviews.llvm.org/D70425#1751548>, @grandinj wrote:

> Perhaps there should be an "= delete" constructor to make this a compile error?


I agree. This seems, as evidenced by our current code, confusing. Make we should have a private constructor for this and clients need to use some APFloat::createFromInt or similar to get this behavior?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70425/new/

https://reviews.llvm.org/D70425





More information about the llvm-commits mailing list