[PATCH] D70394: [DWARF] Add an api to get "interpreted" location lists

Tue Nov 19 06:25:48 PST 2019

labath added inline comments.

================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/statistics-dwo.test:83-84
 CHECK: "call site entries":7
-CHECK: "scope bytes total":2817
-CHECK: "scope bytes covered":506
+CHECK: "scope bytes total":2702
+CHECK: "scope bytes covered":1160
 CHECK: "total function size":594
----------------
dblaikie wrote:
> labath wrote:
> > I haven't checked if these numbers are fully correct, but they should definitely be *more* correct then before, as the code previously did not handle split dwarf location lists at all.
> Might be worth a manual check of the clang binary to see that the numbers remain the same in the cases where it's expected & perhaps that the numbers are the same for split and non-split builds if this change is expected to fix a bug where they were divergent?
Closer examination of this code revealed more problems, so I am going to split the statistics stuff into a separate patch too.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70394/new/

https://reviews.llvm.org/D70394