[PATCH] D70410: Tablegen: Remove the error for duplicate include files.

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 18 23:12:05 PST 2019


rriddle marked an inline comment as done.
rriddle added inline comments.


================
Comment at: llvm/test/TableGen/duplicate-include.inc:1
+
+#ifndef DUPLICATE_INCLUDE
----------------
arsenm wrote:
> Does this need to be moved into an Inputs directory to avoid lit complaining about the lack of run line?
No, the file suffix is '.inc' which isn't marked in the lit.config as being a test suffix. This also matches the convention of some of the other tests in this directory, examples:

https://github.com/llvm/llvm-project/blob/master/llvm/test/TableGen/prep-diag11-include.inc

https://github.com/llvm/llvm-project/blob/master/llvm/test/TableGen/ConstraintChecking.inc



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70410/new/

https://reviews.llvm.org/D70410





More information about the llvm-commits mailing list