[PATCH] D70365: intrinsics attribute opt-out list proposal.

Stefan Stipanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 18 11:53:27 PST 2019


sstefan1 marked an inline comment as done.
sstefan1 added inline comments.


================
Comment at: llvm/utils/TableGen/CodeGenTarget.cpp:754-755
+  // Parse the opt-out intrinsic properties.
+  ListInit *OptOutPropList = R->getValueAsListInit("OptOutIntrProperties");
+  for (unsigned i = 0, e = OptOutPropList->size(); i != e; ++i) {
+    Record *Property = OptOutPropList->getElementAsRecord(i);
----------------
arsenm wrote:
> I think you could avoid touching tablegen by implementing a filter in the tablegen source
I'm not really sure how to do that in tablegen source. Not really used beyond adding properties to intrinsics.

Is there a reason for avoiding current approach?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70365/new/

https://reviews.llvm.org/D70365





More information about the llvm-commits mailing list