[PATCH] D70246: [InstCombine] remove identity shuffle simplification for mask with undefs

Nuno Lopes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 18 06:39:58 PST 2019


nlopes added a comment.

Let me give my 2c: eliminating this transformation is a good thing, since it's incorrect (end-to-end miscompilation testcase in the cited bug report).
It can be re-instated if/when we switch from initializing vectors with undef with poison, but I don't know when that will happen. We'll try to push for the poison patches soonish, but it will take time.
Anyway, thanks Sanjay for handling this :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70246/new/

https://reviews.llvm.org/D70246





More information about the llvm-commits mailing list