[PATCH] D67631: Add AutoUpgrade function to add new address space datalayout string to existing datalayouts.

[Alexander Richardson via Phabricator via llvm-commits]

arichardson added inline comments.


================
Comment at: llvm/trunk/include/llvm/Target/TargetMachine.h:160
   /// check on the validity of this DataLayout.
-  virtual bool isCompatibleDataLayout(const DataLayout &Candidate) const {
+  bool isCompatibleDataLayout(const DataLayout &Candidate) const {
     return DL == Candidate;
----------------
Why was virtual removed here? We override this in the MIPS backend for our CHERI fork.

If the intention is to not allow targets to override this, then the documentation also needs to be adjusted.
However, I doubt avoiding the virtual function call gives any measurable performance speedup.



Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67631/new/

https://reviews.llvm.org/D67631