[PATCH] D69835: Add options for PPC to enable/disable using non-volatile CR

[Stefan Pintilie via Phabricator via llvm-commits]

stefanp added a comment.

I only saw a minor nit with this patch overall.

To address the comment from the previous reviewer I don't feel we should enable this by default on a given CPU even if SPEC does not show significant degradations. This patch effectively tells the register allocator that it should never use the non-volatile CR registers if the option is given. If we make this the default we are effectively abandoning part of our hardware by telling the compiler never to use it. Anyway, that's my opinion on this...



================
Comment at: llvm/test/CodeGen/PowerPC/ppc-disable-non-volatile-cr.ll:32
+if.then:                                          ; preds = %entry
+  tail call void bitcast (void (...)* @fa to void ()*)() #2
+  br label %if.end
----------------
nit: 
You can clean up the `#2` from this line and the other two lines below.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69835/new/

https://reviews.llvm.org/D69835