[PATCH] D70126: [PowerPC] Refactor FinishCall

Jason Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 15 12:28:39 PST 2019


jasonliu added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:5222
+
+void buildCallOperands(SmallVectorImpl<SDValue> &Ops, CallingConv::ID CallConv,
+                       const SDLoc &dl, bool isTailCall, bool isVarArg,
----------------
Could this be a static function? 


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:5232
+
+  // If its a direct call pass the callee as the second operand.
+  if (!isIndirect)
----------------
If it's a direct call, pass ...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70126/new/

https://reviews.llvm.org/D70126





More information about the llvm-commits mailing list