[PATCH] D70263: [Error] Add source location macro

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 15 11:17:14 PST 2019


lhames added a comment.

I'm not sure I follow this. My understanding is that FileError was designed to make it easy to attach a source location to an error generated while operating on a file, but this patch is adapting it to track the LLVM source location that generated the error, right?

I don't think we want to do that -- it makes it very difficult to reason about what FileError's fields mean.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70263/new/

https://reviews.llvm.org/D70263





More information about the llvm-commits mailing list