[PATCH] D70259: [Error] Add source location to cantFail

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 15 11:08:17 PST 2019


lhames added a comment.

Hi Don,

This is a great idea!

I think it would actually be reasonable to have 'cantFail' be the macro though, and move the existing functions (which become an implementation detail) into a detail namespace: We want cantFail to be succinct as part of its value is clarifying flow when we know (from the surrounding context) that errors will not be generated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70259/new/

https://reviews.llvm.org/D70259





More information about the llvm-commits mailing list