[PATCH] D69077: [gicombiner] Add the MatchDag structure and parse instruction DAG's from the input

[Daniel Sanders via Phabricator via llvm-commits]

dsanders marked an inline comment as done.
dsanders added inline comments.


================
Comment at: llvm/utils/TableGen/GICombinerEmitter.cpp:334
+                  to_string(*NameAndDefOp.Matcher) + "");
+      FailedToAddEdges = true;
+    }
----------------
volkan wrote:
> Is there a reason not to add `continue` here? Do we want to keep processing if it failed to add edges?
It's so that we print more errors (if there are any) before we give up. This helps the developer fix all their mistakes in fewer attempts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69077/new/

https://reviews.llvm.org/D69077