[PATCH] D70264: [yaml2obj][test] Move tests to binary format specific subdirectories

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 15 10:14:53 PST 2019


MaskRay added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/empty-symbols.yaml:10
-  Machine:         EM_X86_64
-Symbols:
----------------
jhenderson wrote:
> I might be misreading the intent of the comment, but I think there's value in testing:
> 
> ```
>   Symbols:
> ```
> distinctly from
> ```
>   Symbols: []
> ```
> 
> In other words, can yaml2obj handle it with/without the `[]`.
We probably don't have other tests that check `Symbols:` with the value omitted now.

Added it back with a comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70264/new/

https://reviews.llvm.org/D70264





More information about the llvm-commits mailing list