[PATCH] D70065: [test-suite] Add sollve_vv external project.

[Brian Homerding via Phabricator via llvm-commits]

homerdin added a comment.

Thanks for patch!  It will be great to have this setup available.

Could you add a short README with what the sollve suite is and a quick example for building and controlling the offload flags.



================
Comment at: External/CMakeLists.txt:7
 add_subdirectory(skidmarks10)
+add_subdirectory(sollve_vv)
----------------
>From what I understand the sollve benchmarks are less useful for performance benchmarking, please consider wrapping this `add_subdirectory` with `if(NOT TEST_SUITE_BENCHMARKING_ONLY)` unless I'm mistaken.


================
Comment at: External/sollve_vv/CMakeLists.txt:53
+
+llvm_externals_find(TEST_SUITE_SOLLVEVV_ROOT "sollve_vv" "OpenMP Offloading Validation & Verification Suite")
+if (TEST_SUITE_SOLLVEVV_ROOT)
----------------
It would be nice to be able to checkout the suite into this directory and have it picked up automatically.  I don't know enough about the other external suites to know if this should be put into the `llvm_externals_find` logic.  We could add 

```
if( NOT TEST_SUITE_SOLLVEVV_ROOT)
  if( IS_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/sollve_vv")
    set(TEST_SUITE_SOLLVEVV_ROOT "${CMAKE_CURRENT_SOURCE_DIR}/sollve_vv")
  endif()
endif()
```


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70065/new/

https://reviews.llvm.org/D70065