[PATCH] D70243: Lowering CPI/JTI/BA to assembly

Jason Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 15 07:42:42 PST 2019


jasonliu added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1757
 
+      if (getSubtargetInfo().getTargetTriple().getObjectFormat() ==
+	  Triple::XCOFF) {
----------------
sfertile wrote:
> Nit: Formatting.
We could call member function of triple instead of raw comparison:
TM.getTargetTriple().isOSAIX or TM.getTargetTriple().isOSBinFormatXCOFF
Same for all the raw comparison below. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70243/new/

https://reviews.llvm.org/D70243





More information about the llvm-commits mailing list